Post must be at least 20 characters.
A quick meld folder diff of nemo-preview (which I seem to have found here https://github.com/linuxmint/nemo-extensions/tree/master/nemo-preview) and sushi finds minimal commonality. Directly diffing the two mainWindow.js files basically just matches the GPL headers. So no, your not going magically cherry-pick it over and even if there was a single bit of code that adds that feature you’d have to do a fair bit of work to copy it over…
To a certain extent the “simplist” way to do this is reset back to sushi and re-nemo-ify it, especially when you’ll be missing all the fixes to sushi since the fork
Post must be at least 20 characters.
I didn’t intend to be, I’ve never used Nemo Preview but I’m guessing it’s main difference to Sushi is no GtkHeaderBar - something that should be quite simple to change vs copying bits of sushi over (and figuring out what)
Indeed, I can see how from a users perspective something like this may seem simple. Alas, the simple things are normally hard and often the hard simple.
Sushi fails to preview large shell script files, uses too much CPU
Well a 50 MB file really is rather large, especially with syntax highlighting and GtkSourceView is known to have issues with larger files - I would guess sushi fails to cancel the async file loading hence continued CPU usage when “closed”. But that’s just wild conjecture.
I couldn’t find any other issues from you (ignoring the one that sent you here)
To be fair 22 hours isn’t that long, someone will probably look at it eventually
For this behavior, a new version of the previewer DBus API was implemented. If you search for “previewer” in the commit log, the changes are there https://gitlab.gnome.org/GNOME/nautilus/-/commits/master?utf8=✓&search=previewer
https://gitlab.gnome.org/GNOME/sushi/-/commits/master?utf8=âś“&search=previewer
1 Like
Also, searching for the issue, I found this: https://gitlab.gnome.org/GNOME/sushi/-/issues/5 And it links to the merge requests where the feature was implemented
1 Like
Post must be at least 20 characters.
Post must be at least 20 characters.
Loading the file, as asked. Closing a window isn’t magic - Someone has to hook things up (generally via GCancellable) for the IO task to get cancelled. Something which can easily gets missed and isn’t necessarily trivial to get right.
The fact it’s a massive file, I’d expect the file is already being loaded in chunks (of course text files don’t have pages) but GtkSourceVIew will start to wobble with that much data
These really aren’t comparable, for a number of reasons
Which is wildly different. Something to point out here is sushi doesn’t do overly much, it’s GtkSourceView or GStreamer that actually puts stuff on screen.
It’s not being “allowed“ to do anything. Unfortunately sushi has fairly few contributors (who are of course volunteers) so yes, you probably won’t see any fixes fast. And it’s almost certainly going to be more than a week I’m afarid.
Post must have at least 20 characters.
@RedBearAK Wishing for a better user experience is no excuse for an entitled attitude and harsh tone.
If you “want Linux to be better”, your “venting” has the opposite effect. This is what’s been driving people away from contributing to free and open source software.
While you may not been able to fix the software bugs yourself, you can help fix this social bug.
Quoting our Community Guidelines (part of the COC):
Examples of behavior that contributes to creating a positive environment include:
- Be friendly. Use welcoming and inclusive language.
- Be empathetic. Be respectful of differing viewpoints and experiences.
- Be respectful. When we disagree, we do so in a polite and constructive manner.
- Be considerate. Remember that decisions are often a difficult choice between competing priorities. Focus on what is best for the community. Keep discussions around technology choices constructive and respectful.
- Be patient and generous. If someone asks for help it is because they need it. When documentation is available that answers the question, politely point them to it. If the question is off-topic, suggest a more appropriate online space to seek help.
- Try to be concise. Read the discussion before commenting in order to not repeat a point that has been made.
Post must be at least 20 characters.
This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.