Merge Requests that need attention, 25th September

Happy Friday!

Last week I discussed a weekly review of unloved MR and there seemed quite some interest.

For now, I simplified the idea slightly. This list include only merge-requests by first-time contributors that have had no feedback from anyone.

If you are familiar with one of these projects, perhaps you can usefully review, test or comment on a merge request or two.

Note that most projects reserve the ‘merge’ action for project maintainers. Let’s not actually merge these changes without permission from the relevant project maintainers.

gnome-calendar - Fix crash when hopping between years while still loading calendars

Opened: Sep 16
Author: @SteveNewson
URL: https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/149

gnome-devel-docs - Get rid of duplication: when when -> when

Opened: Sep 16
Author: @yurchor
URL: https://gitlab.gnome.org/GNOME/gnome-devel-docs/-/merge_requests/22

gdm - Xinit: Allow for distros to split system config to /usr/etc

Opened: Sep 16
Author: @DimStar77
URL: https://gitlab.gnome.org/GNOME/gdm/-/merge_requests/110

gdm - Correct a typo in gdm-x-session.c

Opened: Sep 14
Author: @felixonmars
URL: https://gitlab.gnome.org/GNOME/gdm/-/merge_requests/109

gnome-video-effects - Update Danish translation

Opened: Sep 14
Author: @scootergrisen
URL: https://gitlab.gnome.org/GNOME/gnome-video-effects/-/merge_requests/5

babl - Another project can add babl as a meson subproject

Opened: Sep 12
Author: @santouits
URL: https://gitlab.gnome.org/GNOME/babl/-/merge_requests/35

tepl - meson: use version-scripts only when supported

Opened: Sep 11
Author: @tschoonj
URL: https://gitlab.gnome.org/GNOME/tepl/-/merge_requests/8

evince - Stop trusting phsyical dimensions from monitors (Alternative Fix for #1403)

Opened: Sep 10
Author: @MikeVastola
URL: https://gitlab.gnome.org/GNOME/evince/-/merge_requests/279

CITemplates - Do not remove build output before test build step

Opened: Sep 09
Author: @sophie-h
URL: https://gitlab.gnome.org/GNOME/citemplates/-/merge_requests/24

File Roller - Add info to appdata

Opened: Sep 09
Author: @msandova
URL: https://gitlab.gnome.org/GNOME/file-roller/-/merge_requests/43

5 Likes

I don’t particularly agree, here.

The reason why we have a shared GNOME group, with the ability to review/merge changes in every GNOME project, is to encourage drive by reviews and contributions. It allows projects to continue improving without blocking on a single person.

Yes, some maintainers reserve the right to gate all the contributions—that is good and proper. Nevertheless, for changes such as documentation, typo fixes, and improvements in ancillary data, I think we should take advantage of the shared GNOME ownership. This is especially true for shared projects, like the GNOME documentation; the documentation team is small, so the whole community should really take ownership of contributions, there.

2 Likes

I’m happy to hear that. I’d be happier if we had this written and agreed somewhere. Maybe your post will be enough :slight_smile:

1 Like

I think this has been the case for the past 20-odd years, and it’s entirely up to individual maintainers to specify stricter rules, if they so choose. We start from a place of permission, not of restriction. :slight_smile:

In any case, you’re right: we should be more explicit about this policy. I’ll try an open a topic, and then we can modify the wiki.

1 Like

I think this has been the case for the past 20-odd years, and it’s entirely up to individual maintainers to specify stricter rules, if they so choose. We start from a place of permission, not of restriction.

And that does happen. For example, I know (and respect) that pwithnall likes to keep the last word on glib MRs

1 Like

@sthursfield: good job !

So, how does this work wrt access permissions?

Thanks

If you are part of the GNOME group—i.e. you have an LDAP account on GNOME infrastructure—then you have developer access to all projects under the GNOME group on GitLab.

1 Like

So, how does one get an LDAP account in GNOME infrastructure ?

Searching wiki didn’t help.

Thanks

https://wiki.gnome.org/AccountsTeam/NewAccounts describes the process, as well as the pre-requisites.

1 Like

7 posts were split to a new topic: Status of the GNOME wiki

Great idea! I noticed one merge request was nothing more than a typo fix. As that used to be ok to commit, plus again confirmed here I’ve asked to re-enable my account. Apparently it got disabled or something. It’s no fun if people wait 2 weeks for a typo merge request.

Update: Merged two simple typo fixes from a new contributor. As my previous git experience was nothing more than applying a file as a patch the GitLab experience is a little nerve wracking. I’m still terrible with Git, but at least I mostly know when it used to be ok to apply a patch. :stuck_out_tongue:

4 Likes

Git is awesome once you get used to it, but the initial days needs patience to get used to git plumbing.

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.