Merge requests in need of attention, 23rd October 2020

Community
1

Hello! Here are 10 first-contribution merge requests which were opened a week or more ago but have not yet received feedback from anyone. Let’s welcome the contributors and see if we can merge some of them!

librsvg - WIP: (#622): Base Fragment on AllowedUrl instead of plain string

Opened: Oct 15
Author: @Tristramg
URL: https://gitlab.gnome.org/GNOME/librsvg/-/merge_requests/410

pygobject - Fixing build without Cairo

Opened: Oct 15
Author: @jordanlucier
URL: https://gitlab.gnome.org/GNOME/pygobject/-/merge_requests/154

msitools - wixl: Implement SET_PROPERTY custom action

Opened: Oct 15
Author: @heck-gd
URL: https://gitlab.gnome.org/GNOME/msitools/-/merge_requests/27

pygobject - Add Nicotine+ to “Who Is Using PyGObject?”

Opened: Oct 14
Author: @mat
URL: https://gitlab.gnome.org/GNOME/pygobject/-/merge_requests/153

gobject-introspection - giscanner: remove as-needed from linker flags

Opened: Oct 14
Author: @atomsymbol
URL: https://gitlab.gnome.org/GNOME/gobject-introspection/-/merge_requests/247

gtk - gtkmenushell: bind sensitive property to submenus

Opened: Oct 12
Author: @rilian-la-te
URL: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/2684

libxml2 - parser.c: xmlParseCharData peek behavior fixed wrt newlines

Opened: Oct 11 (updated Oct 12)
Author: @flavorjones
URL: https://gitlab.gnome.org/GNOME/libxml2/-/merge_requests/86

NetworkManager-fortisslvpn - 2fa

Opened: Jul 26 (updated Oct 12)
Author: @emelenas
URL: https://gitlab.gnome.org/GNOME/NetworkManager-fortisslvpn/-/merge_requests/19

vala - WIP: Assert failure tests output with RegEx

Opened: Oct 10
Author: @nschrader
URL: https://gitlab.gnome.org/GNOME/vala/-/merge_requests/145

GNOME Tweaks - Done

Opened: Oct 09
Author: @steadydouble9
URL: https://gitlab.gnome.org/GNOME/gnome-tweaks/-/merge_requests/61

4 Likes
2

Thanks @sthursfield, I’ve commented on one of the issues .

It would be nice if there would be a way to get notifications for all new “Merge requests in need of attention”.
@ebassi, would it be possible to create a (sub)category for this? Or a tag?

3

We can definitely create a tag; any particular preference or suggestion?

How about “mr-feedback”? Or “mr-review”? Or “need-reviews”?

1 Like
4

I think mr-feedback sounds nice.

5

I wonder if ‘review-request’ is a useful category name. Glad to know these posts are useful! :slight_smile:

1 Like
6

Categories are mostly for access control; we could have a “Reports” sub-category, but it would still not be useful for this case.

7

Oops, I meant a review-request tag. I’ve been using the ‘Community’ category, which I guess is the most suitable option.

1 Like
8

Review-request sounds fine as well

9

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.