Merge requests in need of attention, 23rd October 2020

Hello! Here are 10 first-contribution merge requests which were opened a week or more ago but have not yet received feedback from anyone. Let’s welcome the contributors and see if we can merge some of them!

librsvg - WIP: (#622): Base Fragment on AllowedUrl instead of plain string

Opened: Oct 15
Author: @Tristramg
URL: WIP: (#622): Base Fragment on AllowedUrl instead of plain string (!410) · Merge requests · GNOME / librsvg · GitLab

pygobject - Fixing build without Cairo

Opened: Oct 15
Author: @jordanlucier
URL: Fixing build without Cairo (!154) · Merge requests · GNOME / pygobject · GitLab

msitools - wixl: Implement SET_PROPERTY custom action

Opened: Oct 15
Author: @heck-gd
URL: wixl: Implement SET_PROPERTY custom action (!27) · Merge requests · GNOME / msitools · GitLab

pygobject - Add Nicotine+ to “Who Is Using PyGObject?”

Opened: Oct 14
Author: @mat
URL: Add Nicotine+ to "Who Is Using PyGObject?" (!153) · Merge requests · GNOME / pygobject · GitLab

gobject-introspection - giscanner: remove as-needed from linker flags

Opened: Oct 14
Author: @atomsymbol
URL: giscanner: remove as-needed from linker flags (!247) · Merge requests · GNOME / gobject-introspection · GitLab

gtk - gtkmenushell: bind sensitive property to submenus

Opened: Oct 12
Author: @rilian-la-te
URL: gtkmenushell: bind sensitive property to submenus (!2684) · Merge requests · GNOME / gtk · GitLab

libxml2 - parser.c: xmlParseCharData peek behavior fixed wrt newlines

Opened: Oct 11 (updated Oct 12)
Author: @flavorjones
URL: parser.c: xmlParseCharData peek behavior fixed wrt newlines (!86) · Merge requests · GNOME / libxml2 · GitLab

NetworkManager-fortisslvpn - 2fa

Opened: Jul 26 (updated Oct 12)
Author: @emelenas
URL: Add 2FA capability to nm-fortisslvpn when the second factor authentication code is sent via SMS/email/etc. (!19) · Merge requests · GNOME / NetworkManager-fortisslvpn · GitLab

vala - WIP: Assert failure tests output with RegEx

Opened: Oct 10
Author: @nschrader
URL: WIP: Assert failure tests output with RegEx (!145) · Merge requests · GNOME / vala · GitLab

GNOME Tweaks - Done

Opened: Oct 09
Author: @steadydouble9
URL: Done (!61) · Merge requests · GNOME / GNOME Tweaks · GitLab

4 Likes

Thanks @sthursfield, I’ve commented on one of the issues .

It would be nice if there would be a way to get notifications for all new “Merge requests in need of attention”.
@ebassi, would it be possible to create a (sub)category for this? Or a tag?

We can definitely create a tag; any particular preference or suggestion?

How about “mr-feedback”? Or “mr-review”? Or “need-reviews”?

1 Like

I think mr-feedback sounds nice.

I wonder if ‘review-request’ is a useful category name. Glad to know these posts are useful! :slight_smile:

1 Like

Categories are mostly for access control; we could have a “Reports” sub-category, but it would still not be useful for this case.

Oops, I meant a review-request tag. I’ve been using the ‘Community’ category, which I guess is the most suitable option.

1 Like

Review-request sounds fine as well

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.