Merge requests in need of attention, 18th December 2020

[sthursfield (Sam Thursfield)]

This list shows some first-contribution merge requests which were opened a week or more ago but have not yet received feedback.

I thought we didn’t have many new additions, but in fact my script broke Here some fresher merge requests,

alacarte - Resize input fields with launcher dialog.

Opened: Dec 09
Author: @SubOptimal
URL: ItemEditor: resize input fields with launcher dialog (!5) · Merge requests · GNOME / alacarte · GitLab

gnome-mines - Added spaces in description for consistency #60

Opened: Dec 08
Author: @DylanRichards
URL: Added spaces in description for consistency #60 (!27) · Merge requests · GNOME / gnome-mines · GitLab

libgtop - Add support for GPU metrics

Opened: Dec 06 (updated Dec 08)
Author: @siavashs
URL: Add support for GPU metrics (!16) · Merge requests · GNOME / libgtop · GitLab

libnotify - notify-send: Support commas in icon filenames

Opened: Dec 07
Author: @thorsten_
URL: notify-send: Support commas in icon filenames (!15) · Merge requests · GNOME / libnotify · GitLab

quadrapassel - fixed issue#2

Opened: Dec 03 (updated Dec 07)
Author: @aliyarahmani786
URL: fixed issue#2 (!26) · Merge requests · GNOME / quadrapassel · GitLab

evince - Windows: compilation failed because PathFindExtension() need shlwapi DLL

Opened: Dec 06
Author: @vtorri
URL: Windows: compilation failed because PathFindExtension() need shlwapi DLL (!292) · Merge requests · GNOME / evince · GitLab

evince - Windows: open() and al. need io.h

Opened: Dec 06
Author: @vtorri
URL: Windows: open() and al. need io.h (!293) · Merge requests · GNOME / evince · GitLab

evince - Windows: fix compilation, CLOEXEC does not exist

Opened: Dec 06
Author: @vtorri
URL: Windows: fix compilation, CLOEXEC does not exist (!291) · Merge requests · GNOME / evince · GitLab

accerciser - Added Indonesian translation

Opened: Dec 06
Author: @andika
URL: Added Indonesian translation (!11) · Merge requests · GNOME / accerciser · GitLab

gnome-calendar - Move month forwards/backwards when clicking a date outside of the current month in Month View.

Opened: Dec 04
Author: @cchillen
URL: Move month forwards/backwards when clicking a date outside of the current month in Month View. (!154) · Merge requests · GNOME / gnome-calendar · GitLab

[ptomato (Philip Chimento)]

I do wonder what the etiquette is for merging these merge requests — I sometimes have time to review them, but I don’t want to stomp on the maintainers by merging them. I wonder if the script could mark ones that have had a review but not been merged yet after another week or so? Then we could merge those.

[sthursfield (Sam Thursfield)]

That’s an interesting idea, although I can’t immediately see an easy way to implement it. I feel the same as you that I don’t want to incur the wrath of the incumbent maintainer.

One thing I am planning is making a table of “who maintains what” using the DOAP data in the repos. Perhaps there’s some info we could add to this table that’d make it clearer how actively maintained a project is. It would at least make it easier to see who to check with before merging.

[ebassi (Emmanuele Bassi)]

You can probably check when was the last non-translation commit, and if the committer was listed in the DOAP file.

[vanadiae]

The problem is that even if there’s some people set as maintainers in the DOAP, it doesn’t actually mean the project is maintained. There isn’t even anybody to remove those people from the DOAP since there’s no active maintainer

[sthursfield (Sam Thursfield)]

That’s exactly the kind of thing that I hope we can improve. If the listed maintainers are inactive, then it’s all the more important that the rest of us encourage new contributors, by reviewing and merging things ourselves.

[vanadiae]

Sure, I agree it’s important to not let contributions unreviewed and un-noticed

[sthursfield (Sam Thursfield)]

I wonder if the script could mark ones that have had a review but not been merged yet after another week or so? Then we could merge those.

Thinking about this some more, what if I link to the previous week’s post each time I post a new list? That lets us see everything from the previous week, at least.